problem_report: avoid double .txt file extension#590
Open
bdrung wants to merge 2 commits intocanonical:mainfrom
Open
problem_report: avoid double .txt file extension#590bdrung wants to merge 2 commits intocanonical:mainfrom
bdrung wants to merge 2 commits intocanonical:mainfrom
Conversation
bdrung
force-pushed
the
fix-double-extension
branch
from
eb5e305 to
d63084b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #590 +/- ##
=======================================
Coverage 84.51% 84.52%
=======================================
Files 104 104
Lines 20988 20991 +3
Branches 3218 3218
=======================================
+ Hits 17739 17742 +3
- Misses 2808 2809 +1
+ Partials 441 440 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bdrung
force-pushed
the
fix-double-extension
branch
from
d63084b to
ba1b5d4
Compare
Refactor `problem_report.py` by introducing the helper function `_create_text_attachment` in preparation for following commits. Bug: https://launchpad.net/bugs/2149892 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Some bug reports like bug #2147517 have an attachment with double file extension: `CurrentDmesg.txt.txt` Do not add `.txt` in case the key name already contains the file extension. Bug: https://launchpad.net/bugs/2149892 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
bdrung
force-pushed
the
fix-double-extension
branch
from
ba1b5d4 to
05d7d77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some bug reports like bug #2147517 have an attachment with double file extension:
CurrentDmesg.txt.txtDo not add
.txtin case the key name already contains the file extension.This PR is stacked on top of #576
Bug: https://launchpad.net/bugs/2149892